diff --git a/cinera/cinera.c b/cinera/cinera.c index a0c0242..bc51fa5 100644 --- a/cinera/cinera.c +++ b/cinera/cinera.c @@ -14,7 +14,7 @@ typedef struct version CINERA_APP_VERSION = { .Major = 0, .Minor = 5, - .Patch = 31 + .Patch = 32 }; // TODO(matt): Copy in the DB 3 stuff from cinera_working.c @@ -1162,10 +1162,11 @@ BuildCredits(buffer *CreditsMenu, bool *HasCreditsMenu, HMML_VideoMetaData *Meta { if(SearchCredentials(CreditsMenu, HasCreditsMenu, Metadata->member, "Host")) { - printf("No credentials for %s. Please contact matt@handmadedev.org with their:\n" + printf("No credentials for member %s. Please contact matt@handmadedev.org with their:\n" " Full name\n" " Homepage URL (optional)\n" " Financial support info, e.g. Patreon URL (optional)\n", Metadata->member); + return CreditsError_NoCredentials; } } else @@ -1176,6 +1177,7 @@ BuildCredits(buffer *CreditsMenu, bool *HasCreditsMenu, HMML_VideoMetaData *Meta " \n" " \n"); } + fprintf(stderr, "Missing \"member\" in the [video] node\n"); return CreditsError_NoHost; } @@ -1185,10 +1187,11 @@ BuildCredits(buffer *CreditsMenu, bool *HasCreditsMenu, HMML_VideoMetaData *Meta { if(SearchCredentials(CreditsMenu, HasCreditsMenu, Metadata->co_hosts[i], "Co-host")) { - printf("No credentials for %s. Please contact matt@handmadedev.org with their:\n" + printf("No credentials for co-host %s. Please contact matt@handmadedev.org with their:\n" " Full name\n" " Homepage URL (optional)\n" " Financial support info, e.g. Patreon URL (optional)\n", Metadata->co_hosts[i]); + return CreditsError_NoCredentials; } } } @@ -1199,10 +1202,11 @@ BuildCredits(buffer *CreditsMenu, bool *HasCreditsMenu, HMML_VideoMetaData *Meta { if(SearchCredentials(CreditsMenu, HasCreditsMenu, Metadata->guests[i], "Guest")) { - printf("No credentials for %s. Please contact matt@handmadedev.org with their:\n" + printf("No credentials for guest %s. Please contact matt@handmadedev.org with their:\n" " Full name\n" " Homepage URL (optional)\n" " Financial support info, e.g. Patreon URL (optional)\n", Metadata->guests[i]); + return CreditsError_NoCredentials; } } } @@ -1213,10 +1217,11 @@ BuildCredits(buffer *CreditsMenu, bool *HasCreditsMenu, HMML_VideoMetaData *Meta { if(SearchCredentials(CreditsMenu, HasCreditsMenu, Metadata->annotators[i], "Annotator")) { - printf("No credentials for %s. Please contact matt@handmadedev.org with their:\n" + printf("No credentials for annotator %s. Please contact matt@handmadedev.org with their:\n" " Full name\n" " Homepage URL (optional)\n" " Financial support info, e.g. Patreon URL (optional)\n", Metadata->annotators[i]); + return CreditsError_NoCredentials; } } } @@ -1228,6 +1233,7 @@ BuildCredits(buffer *CreditsMenu, bool *HasCreditsMenu, HMML_VideoMetaData *Meta " \n" " \n"); } + fprintf(stderr, "Missing \"annotator\" in the [video] node\n"); return CreditsError_NoAnnotator; } @@ -1238,7 +1244,7 @@ BuildCredits(buffer *CreditsMenu, bool *HasCreditsMenu, HMML_VideoMetaData *Meta " \n"); } - return 0; + return RC_SUCCESS; } int @@ -2275,6 +2281,16 @@ MediumExists(char *Medium) return FALSE; } +#define HMMLCleanup() \ + DeclaimBuffer(&FilterState); \ + DeclaimBuffer(&CreditsMenu); \ + DeclaimBuffer(&FilterMedia); \ + DeclaimBuffer(&FilterTopics); \ + DeclaimBuffer(&FilterMenu); \ + DeclaimBuffer(&ReferenceMenu); \ + DeclaimBuffer(&QuoteMenu); \ + hmml_free(&HMML); + int HMMLToBuffers(buffers *CollationBuffers, template **BespokeTemplate, char *Filename) { @@ -2468,22 +2484,14 @@ HMMLToBuffers(buffers *CollationBuffers, template **BespokeTemplate, char *Filen "
\n" "