The search page could auto-scroll to the top when the grid is not
displayed. This commit fixes that problem by ensuring that the grid
element has a width and height before seeking to auto-scroll to it.
Thanks to Leonardo Serafim Eid for the report
• Max{Height,Width}OfElement() should now produce saner values
• Video can now resize upon orientation change on mobile
• Search grid now sizes to the correct area
• CSS rule setting only tries to touch local stylesheets
• Video size may be based on the height if the width-based is too tall
• Auto-scrolling improvements:
• It now cannot oscillate
• It doesn't happen at all if scrolled to the very top / bottom
Thanks to @Freak_ on freenode for the report
Better text fitting
Account for the scrollbar width in our max width considerations
Don't bother to compute the grid size merely when toggling the view
Both pages:
Derive reliable window dimensions ourselves
Set the orientation from the window dimensions
Use "box-sizing: content-box" on the help keys, to fix sizing
Search page:
Support irregular (i.e. non-square) grids
General sizing fixes
Fix text fitting when toggling back from List to Grid view
Fix text fitting when textNode would overflow container
Correctly compute optimal grid size after orientation change
Rename .text to .cineraText to avoid CSS selector clash
Only add click events for the main set of buttons (not its clone)
Player page:
Size the video and timestamps bar more sensibly
Search page:
Manually size the grid buttons, and head / tail items
Player page:
Confine long menus to the player height
Confine the help documentation to the window size
Major features:
Search page: Subdivision grid layout
Player page: Device orientation-specific layout
Fixes:
Strip slashes of the URLs: base_url, etc.
Fix SnipeChecksumAndCloseFile() to not null-terminate the checksum string
Fix hover background colouration of medium icons of current timestamp
Fix DeriveLineageWithoutOriginOfProject() to call InitBookOfPointers()
Fix SortAndAbbreviateSpeakers() to use the person's ID if Name is blank
More directly display the "unit", if set, in the search results
Fix VideoIsPrivate() to find the apparently relocated privacyStatus
Make VideoIsPrivate() default to TRUE for non-youtube
Output as keywords all topics that do not match "nullTopic"
Deleted asset:
cinera_search.js
New assets:
cinera_search_pre.js
cinera_search_post.js
Fixes / Improvements:
• Switch all growable arrays to use memory_book, rather than realloc()
• Lift a bunch of hardcoded string lengths and item counts
• malloc() the MemoryArena rather than calloc(), thus saving 3 MiB
• Reorganise HMMLToBuffers() to return from one place, the end
• Print indexing errors in the same style as config errors / warnings
Diagnoses:
• Identified sources of "non-freed" memory usage and marked them +MEM.
This may aid future work on further reducing memory / cycle usage.
New config settings:
• suppress_prompts boolean
• Segfault was due to a read access violation on an unset entry pointer,
which in turn was due to stale neighbourhood data. To fix it we simply
reset the neighbourhood when starting to delete an entry. Additionally
we now check that those entry pointers are set before accessing them.
• Event handling of the trio of events triggered when vim saves a file.
We now read in a second set of events while processing the first if we
were on the verge of processing a deletion. If we get any more events,
we continue to squash those ones if possible, to always end up having
seen the entire trio of events associated with a file save, and then
process it as an insertion / reinsertion, not a deletion.
• Sort the asset landmarks by their offset.
• Change GenerateTopicColours() to initially open cinera_topics.css as
"r" to search it for the incoming topic, and only if that topic is
absent reopen it as "a+", thus triggering an IN_CLOSE_WRITE event.
It was just a typo. HMMLToBuffers() passed the global config pointer,
rather than the passed in one, to GenerateNavigation().
Also switch the entire config over to use memory_book style allocation.
This saves us from having to offset pointers when memory gets realloc'd.
Config parsing now errors-out when it detects clashes between:
base_dir and search_location, and global_search_dir
base_dir and player_location
This prevents us from generating search / project pages of multiple
projects (incl. global_search_dir) at the same location, which would
screw up the asset landmarks.
This change makes GenerateGlobalSearchPage() pass the Config to
BuffersToHTML(), which in turn passes it on to GenerateNavigation(),
thus preventing a null-pointer deference when setting the Theme.
It also fixes the filter by using all three of baseURL, searchLocation
and playerLocation to associate the filter and index elements.
On the search pages use the search_location and player_location, in
addition to the base_url, to associate filter and index entries, such
that the filter actually works.
Fix the .index file location for projects with a search_location. As
this is now consistent, we happen to fix a crash that happened when
changing the search_location.
New config option:
deny_bespoke_templates
Indexers may use the "template" attribute in the video node of
an .hmml file to set a bespoke template for that entry,
superseding any configured player_template. Setting
"deny_bespoke_templates" to true prevents this.
• Pack all templates before sync'ing the projects
• Delay generation of navigation bars until BuffersToHTML(), and free them
when switching projects
• Change many variably-lengthed items to use memory_book
• Do not push on multiple support scopes with the same ID
• Prevent crash when trying to snipe an asset checksum into an HTML file
we were never permitted to create
• Reorganise ReadFileIntoBuffer() and related functions into cinera.c
New Template Tags:
__CINERA_GLOBAL_NAV__
Passing an empty string to StripSlashes() would crash.
Also add a conditional around the ctime calls in the Won Build System,
to only run it if it exists.
Matt Mascarenhas
Alex Baines
Matt Mascarenhas