bvisness
  • Joined on 2021-12-04
bvisness pushed to jam-2022 at hmn/hmn 2022-08-07 04:12:30 +00:00
9f88ce1223 something something colors
bvisness pushed to jam-2022 at hmn/hmn 2022-08-07 03:32:48 +00:00
4289a1e27a Improvements to snippet edit
bvisness pushed to jam-2022 at hmn/hmn 2022-08-07 01:21:27 +00:00
48490d83a9 Some tweaks
bvisness pushed to jam-2022 at hmn/hmn 2022-08-05 05:04:31 +00:00
41c2b6e111 Make slightly more prettier
bvisness commented on pull request hmn/hmn#85 2022-08-05 05:03:20 +00:00
Snippet creation and editing on the website.

Will this command be necessary after we we roll this out, or is it a one-time thing?

bvisness commented on pull request hmn/hmn#85 2022-08-05 05:03:20 +00:00
Snippet creation and editing on the website.

No need for this or any other res.Body.Close() if you defer above like is recommended.

bvisness commented on pull request hmn/hmn#85 2022-08-05 05:03:20 +00:00
Snippet creation and editing on the website.

Need to defer res.Body.Close() on this too.

bvisness commented on pull request hmn/hmn#85 2022-08-05 05:03:20 +00:00
Snippet creation and editing on the website.

I don't think it really matters, but you could simply use FindAllSubmatch on partialHtml instead of converting to a string and using FindAllStringSubmatch. Everything in the regexp package has byte[] and string equivalents.

bvisness commented on pull request hmn/hmn#85 2022-08-05 05:03:20 +00:00
Snippet creation and editing on the website.

Also, naming nitpick, I think we could name this metaTags or something because I got confused and had to look back up to see what matches was actually matching.

bvisness commented on pull request hmn/hmn#85 2022-08-05 05:03:20 +00:00
Snippet creation and editing on the website.

Is it even possible for this if statement to be false? For each matched meta tag, you should always have a slice with two elements.

bvisness commented on pull request hmn/hmn#85 2022-08-05 05:03:20 +00:00
Snippet creation and editing on the website.

What is prop used for? I'm confused. We don't seem to return it or use it in any way?

bvisness commented on pull request hmn/hmn#85 2022-08-05 05:03:20 +00:00
Snippet creation and editing on the website.

It's recommended that http.Client is reused where possible instead of created every time, because the client's Transport has an internal cache that is good to keep around. (See the docs.) So I think this should be moved to a package-level variable.

bvisness commented on pull request hmn/hmn#85 2022-08-05 05:03:20 +00:00
Snippet creation and editing on the website.

You should defer res.Body.Close() right after this so you don't have to worry about it elsewhere. (This is what they do in the http package docs.)

bvisness commented on pull request hmn/hmn#85 2022-08-05 05:03:20 +00:00
Snippet creation and editing on the website.

I actually already added gap helpers - g1, g2, etc.

bvisness commented on pull request hmn/hmn#85 2022-08-05 05:03:20 +00:00
Snippet creation and editing on the website.

Gross. I don't have a better idea, but gross.

bvisness suggested changes for hmn/hmn#85 2022-08-05 05:03:20 +00:00
Snippet creation and editing on the website.
bvisness commented on pull request hmn/hmn#85 2022-08-05 04:46:55 +00:00
Snippet creation and editing on the website.

Also, naming nitpick, I think we could name this metaTags or something because I got confused and had to look back up to see what matches was actually matching.

bvisness pushed to jam-2022 at hmn/hmn 2022-08-05 04:22:42 +00:00
1b79f45d71 Make the feed page nicer
bvisness pushed to jam-2022 at hmn/hmn 2022-08-05 02:00:23 +00:00
92b175c84d Make good pretty jam wow much good
bvisness pushed to jam-2022 at hmn/hmn 2022-08-04 23:37:59 +00:00
62972ae35a Merge remote-tracking branch 'origin/master' into jam-2022
09652c4146 Re-apply the avatar change
081186c8f0 Add automatic scrolling behavior to jam carousel
ba667f717e Fix overflow issues with new jam stuff
e84754eda0 Add last year's projects to the jam page
Compare 30 commits »