bvisness
  • Joined on 2021-12-04
bvisness opened issue hmn/hmn#74 2022-07-25 20:19:30 +00:00
Buttons are dim and boring
bvisness commented on issue hmn/hmn#66 2022-07-25 20:17:05 +00:00
Discord embed colors should match our brand

Reopening because I feel like we need a better fallback than #ffffff, and personal projects need some reasonable behavior here...colors, man, I tell ya

bvisness reopened issue hmn/hmn#66 2022-07-25 20:17:05 +00:00
Discord embed colors should match our brand
bvisness merged pull request hmn/hmn#71 2022-07-25 20:16:05 +00:00
Set meta tag theme color to project's theme color
bvisness closed issue hmn/hmn#66 2022-07-25 20:16:05 +00:00
Discord embed colors should match our brand
bvisness pushed to master at hmn/hmn 2022-07-25 20:16:05 +00:00
4b3e38ee02 Set meta tag theme color to project's theme color (#71)
bvisness commented on pull request hmn/hmn#71 2022-07-25 20:14:58 +00:00
Set meta tag theme color to project's theme color

Oh! Personal projects, right. I'm not sure what the best way is to handle that. Keep what you have for now, and I can figure something else out later if it's a problem.

bvisness commented on pull request hmn/hmn#73 2022-07-25 17:12:34 +00:00
New project link changed to a bigger button

This looks like broken syntax.

bvisness commented on pull request hmn/hmn#73 2022-07-25 17:12:34 +00:00
New project link changed to a bigger button

Also - we actually do already have some styles for links that look like buttons, using the classname button. If you remove your custom CSS for .button, you should already see some styles take effect on this link. How does it look if you keep class="button" but remove your custom CSS?

bvisness commented on pull request hmn/hmn#73 2022-07-25 17:12:34 +00:00
New project link changed to a bigger button

This extra closing brace is a syntax error.

bvisness commented on pull request hmn/hmn#73 2022-07-25 17:12:34 +00:00
New project link changed to a bigger button

We use rem for our spacing and padding instead of px so that the site plays nice with different choices of default font size. We also have lots of utility CSS classes to help us out with this. For example, since I see you want more padding on the sides than on the top and bottom, you could simply put the classes pv2 ph3 on the button. (pv2 = padding vertical 2, ph3 = padding vertical 3.) This helps us use consistent spacing across the site, and makes it easier to do basic layout since we don't have to write a custom CSS class for everything.

bvisness suggested changes for hmn/hmn#73 2022-07-25 17:12:34 +00:00
New project link changed to a bigger button

Thanks for your contribution! It looks good visually, but the styles are currently in conflict with some other styles in the website. I left some specific comments, but the thrust of it is that we already have a button class for links that should get us most of the way, and padding helpers besides. I'd like to start there to ensure that this button's styles are reasonably consistent with the rest of the site.

bvisness commented on pull request hmn/hmn#73 2022-07-25 17:04:42 +00:00
New project link changed to a bigger button

Also - we actually do already have some styles for links that look like buttons, using the classname button. If you remove your custom CSS for .button, you should already see some styles take…

bvisness commented on pull request hmn/hmn#71 2022-07-25 16:37:44 +00:00
Set meta tag theme color to project's theme color

Do we need the if statement here? I can't imagine a situation in which we wouldn't have .Project (since we have a dummy "project" for the main parts of the site).

bvisness commented on issue hmn/hmn#69 2022-07-25 16:36:17 +00:00
Add conference links to the nav somehow

Yes I think this would do just fine for now. The conferences page there looks a bit bare, but that's not a big concern. Do whatever you want for the presentation here, create a PR, and I'll take…

bvisness pushed to education at hmn/hmn 2022-07-23 17:34:30 +00:00
2f55fd7ebd Fix tests, remove unused admin page and code
bvisness pushed to education at hmn/hmn 2022-07-23 17:28:41 +00:00
ed90ebc005 Add a sidebar
bvisness pushed to education at hmn/hmn 2022-07-23 17:10:36 +00:00
0e719a5086 Beef up index or something
a5dad79012 Add ability to delete articles
Compare 2 commits »
bvisness pushed to education at hmn/hmn 2022-07-23 01:57:09 +00:00
2d51c90f7b Add editing of education resources
d2d651e124 Check duplicates, redirect to the right place
969b34b1a6 Base creation of education articles
2d4b405b06 Improve error reporting from db package
40054f8e07 Fix seeding (and guess more passwords)
Compare 10 commits »
bvisness pushed to master at hmn/hmn 2022-07-23 01:56:34 +00:00
d3f5057d41 Edit scripts too, oops