Reopening because I feel like we need a better fallback than #ffffff
, and personal projects need some reasonable behavior here...colors, man, I tell ya
Oh! Personal projects, right. I'm not sure what the best way is to handle that. Keep what you have for now, and I can figure something else out later if it's a problem.
Also - we actually do already have some styles for links that look like buttons, using the classname button
. If you remove your custom CSS for .button
, you should already see some styles take effect on this link. How does it look if you keep class="button"
but remove your custom CSS?
We use rem
for our spacing and padding instead of px
so that the site plays nice with different choices of default font size. We also have lots of utility CSS classes to help us out with this. For example, since I see you want more padding on the sides than on the top and bottom, you could simply put the classes pv2 ph3
on the button. (pv2
= padding vertical 2, ph3
= padding vertical 3.) This helps us use consistent spacing across the site, and makes it easier to do basic layout since we don't have to write a custom CSS class for everything.
Thanks for your contribution! It looks good visually, but the styles are currently in conflict with some other styles in the website. I left some specific comments, but the thrust of it is that we already have a button
class for links that should get us most of the way, and padding helpers besides. I'd like to start there to ensure that this button's styles are reasonably consistent with the rest of the site.
Also - we actually do already have some styles for links that look like buttons, using the classname button
. If you remove your custom CSS for .button
, you should already see some styles take…
Do we need the if statement here? I can't imagine a situation in which we wouldn't have .Project
(since we have a dummy "project" for the main parts of the site).
Yes I think this would do just fine for now. The conferences page there looks a bit bare, but that's not a big concern. Do whatever you want for the presentation here, create a PR, and I'll take…