bvisness
  • Joined on 2021-12-04
bvisness pushed to beta at hmn/hmn 2022-02-12 07:11:57 +00:00
b45a28156c Add projects to profile user command
bvisness pushed to master at hmn/hmn 2022-02-12 07:00:57 +00:00
b45a28156c Add projects to profile user command
bvisness commented on pull request hmn/hmn#2 2022-02-03 15:20:01 +00:00
discord_messages

Oh, never mind then.

bvisness commented on pull request hmn/hmn#2 2022-02-03 15:19:18 +00:00
discord_messages

Gotcha, that makes sense - let's at least log the message ID in this case though.

bvisness commented on pull request hmn/hmn#2 2022-02-03 01:44:13 +00:00
discord_messages

Is it actually an error to not find an interned message in our db? I would expect that to be relatively likely, although I guess the live websocket connection would probably do that before a scrape.

bvisness commented on pull request hmn/hmn#2 2022-02-03 01:44:13 +00:00
discord_messages

Yeah this clearly seems like a bug. Seems like we should be setting this, or perhaps even storing this value in the database...let's just set it here for now though.

bvisness commented on pull request hmn/hmn#2 2022-02-03 01:44:13 +00:00
discord_messages

If we're going to be manually resetting the ticker after every tick, it might as well not be a ticker.

bvisness commented on pull request hmn/hmn#2 2022-02-03 01:44:13 +00:00
discord_messages

Ok, yet more reasons to update and verify this in all kinds of uses. Testing!!!

bvisness commented on pull request hmn/hmn#2 2022-02-03 01:44:13 +00:00
discord_messages

What happens if the user updates a message to remove a tag? Is there any path that will un-tag the snippet? Do we want that?

bvisness commented on pull request hmn/hmn#2 2022-02-03 01:44:13 +00:00
discord_messages

Same concerns about application commands and early returns apply here.

bvisness commented on pull request hmn/hmn#2 2022-02-03 01:44:13 +00:00
discord_messages

Do you want to handle that in this first pass? Seems like we should do something if the user does something that causes the message to be deleted - but would that cascade through this snippet elsewhere?

bvisness commented on pull request hmn/hmn#2 2022-02-03 01:44:13 +00:00
discord_messages

Random thought based on usage I saw on HMN - we need to make sure the tag parser can recognize tags in situations like:

bvisness commented on pull request hmn/hmn#2 2022-02-03 01:44:13 +00:00
discord_messages

Why does this start out true? Is this what makes application commands work?

bvisness commented on pull request hmn/hmn#2 2022-02-03 01:44:13 +00:00
discord_messages

Comment is clearly in the wrong place - I'm guessing also outdated?

bvisness commented on pull request hmn/hmn#2 2022-02-03 01:44:13 +00:00
discord_messages

capital L! reeeeeeee

bvisness commented on pull request hmn/hmn#2 2022-02-03 01:44:13 +00:00
discord_messages

If we think we might add more to this chain in the future, maybe we should add a setup like

bvisness commented on pull request hmn/hmn#2 2022-02-03 01:44:13 +00:00
discord_messages

Do we want to include application commands here? Seems maybe wrong. We probably won't be able to respond inline in the channel without the response getting nuked...

bvisness commented on pull request hmn/hmn#2 2022-02-03 01:44:13 +00:00
discord_messages

This all might be easier with an early return, if you feel like it.

bvisness commented on pull request hmn/hmn#2 2022-02-03 01:44:13 +00:00
discord_messages

We should add some text to the profile settings page informing the user of this.

bvisness commented on pull request hmn/hmn#2 2022-02-03 01:44:13 +00:00
discord_messages

These descriptions are no longer correct.