From ad904de16b345723f139d29059505effe9e3a3cd Mon Sep 17 00:00:00 2001 From: Jake Mason Date: Mon, 16 Jan 2023 22:24:44 -0500 Subject: [PATCH] Removing hrefs like this is breaks a11y entirely --- src/templates/src/include/header.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/templates/src/include/header.html b/src/templates/src/include/header.html index de97eb7..be26990 100644 --- a/src/templates/src/include/header.html +++ b/src/templates/src/include/header.html @@ -139,9 +139,9 @@ const loginLink = document.getElementById("login-link"); if (loginPopup !== null) { - loginLink.removeAttribute("href"); - loginLink.onclick = () => { + loginLink.onclick = (e) => { + e.preventDefault(); loginPopup.classList.toggle("open"); } }