Forum threads can be accessed from any subforum slug #12

New Issue

bvisness · 2022-05-21T22:30:14Z

bvisness commented

2022-05-21 22:30:14 +00:00

At the moment it seems that forum posts can be accessed through any subforum's URL. This is because ultimately we just look for the post ID in the URL, and the subforum slugs are only used for breadcrumbs and such.

An example of this is Sharlock's excellent post on creating a PNG reader from scratch.

Correct:
https://handmade.network/forums/articles/t/2363-implementing_a_basic_png_reader_the_handmade_way
Incorrect (currently works, but should not):
https://handmade.network/forums/wip/t/2363-implementing_a_basic_png_reader_the_handmade_way

Accessing a thread with the wrong subforum slugs should redirect to the correct subforum slugs.

At the moment it seems that forum posts can be accessed through any subforum's URL. This is because ultimately we just look for the post ID in the URL, and the subforum slugs are only used for breadcrumbs and such. An example of this is Sharlock's excellent post on creating a PNG reader from scratch. Correct: https://handmade.network/forums/articles/t/2363-implementing_a_basic_png_reader_the_handmade_way Incorrect (currently works, but should not): https://handmade.network/forums/wip/t/2363-implementing_a_basic_png_reader_the_handmade_way Accessing a thread with the wrong subforum slugs should redirect to the correct subforum slugs.

bvisness added the

bug

good first issue

labels 2022-05-21 22:30:14 +00:00

AsafGartner referenced this issue from a commit

2022-06-15 21:34:57 +00:00

Added proper verification for forum urls

AsafGartner closed this issue

2022-06-15 21:39:47 +00:00

Sign in to join this conversation.