Copy drag/drop from blog edit to project (#6) #77

Merged
bvisness merged 2 commits from mark.dev/hmn:master into master 2022-08-02 02:01:56 +00:00
Contributor

I migrated the relevant parts of editor.html and forums.go (via blogs.go) into project_edit.html and projects.go.

Let me know if you would prefer pulling the shared javascript into a shared file. Only some variable names were changed.

I did not test the case where the upload fails.

I migrated the relevant parts of `editor.html` and `forums.go` (via `blogs.go`) into `project_edit.html` and `projects.go`. Let me know if you would prefer pulling the shared javascript into a shared file. Only some variable names were changed. I did not test the case where the upload fails.
1002 KiB
mark.dev added 1 commit 2022-07-28 02:03:47 +00:00
Owner

Fantastic, thank you for doing this! I do think we should put the asset uploading JS into a separate script though, since it's really quite a lot of duplicated code and I guarantee we'll forget to update one or the other in the future. If you want to do that I'd appreciate it, otherwise I can just do it later when I eventually clean up some PRs and issues.

Fantastic, thank you for doing this! I do think we should put the asset uploading JS into a separate script though, since it's really quite a lot of duplicated code and I guarantee we'll forget to update one or the other in the future. If you want to do that I'd appreciate it, otherwise I can just do it later when I eventually clean up some PRs and issues.
Author
Contributor

Sure thing, I'll do it.

Sure thing, I'll do it.
mark.dev force-pushed master from 213f90a0b1 to 224e4a3e1c 2022-07-30 19:42:39 +00:00 Compare
Author
Contributor

@bvisness done

@bvisness done
Owner

Looks great! Thank you so much. I'll get this tested and deployed soon.

Looks great! Thank you so much. I'll get this tested and deployed soon.
bvisness merged commit a295d0ed52 into master 2022-08-02 02:01:56 +00:00
Sign in to join this conversation.
No description provided.