Launching Orca stops discord screen sharing on macOS #15

New Issue

MartinFouilleul · 2023-07-06T08:13:17Z

MartinFouilleul commented

2023-07-06 08:13:17 +00:00

MBP 16' 2019 - Intel Core i9
macOS Catalina - 10.15.4

MBP 16' 2019 - Intel Core i9 macOS Catalina - 10.15.4

MartinFouilleul self-assigned this 2023-07-06 08:13:27 +00:00

MartinFouilleul commented

2023-07-06 17:40:25 +00:00

So, this is weird...
The screen sharing disconnect happens when we set the metal layer's device property:

surface->device = MTLCreateSystemDefaultDevice();
[surface->device retain];
surface->mtlLayer = [CAMetalLayer layer];
[surface->mtlLayer retain];
[surface->interface.layer.caLayer addSublayer: (CALayer*)surface->mtlLayer];

surface->mtlLayer.device = surface->device;

If I don't call MTLCreateSystemDefaultDevice() and set the layer's device to layer.preferredDevice instead, it doesn't hang the screen sharing... even though this is the same value that's returned by MTLCreateSystemDefaultDevice().

To note, this Apple sample showing how to create a metal layer sets the layer's device property to the return value of MTLCreateSystemDefaultDevice(), and it does hang Discord's screen sharing.

So, this is weird... The screen sharing disconnect happens when we set the metal layer's `device` property: ``` surface->device = MTLCreateSystemDefaultDevice(); [surface->device retain]; surface->mtlLayer = [CAMetalLayer layer]; [surface->mtlLayer retain]; [surface->interface.layer.caLayer addSublayer: (CALayer*)surface->mtlLayer]; surface->mtlLayer.device = surface->device; ``` If I don't call `MTLCreateSystemDefaultDevice()` and set the layer's device to `layer.preferredDevice` instead, it doesn't hang the screen sharing... even though this is the same value that's returned by `MTLCreateSystemDefaultDevice()`. To note, this [Apple sample](https://developer.apple.com/documentation/metal/onscreen_presentation/creating_a_custom_metal_view?language=objc) showing how to create a metal layer sets the layer's device property to the return value of `MTLCreateSystemDefaultDevice()`, and it does hang Discord's screen sharing.

MartinFouilleul commented

2023-07-07 08:56:55 +00:00

I'll just use layer.preferredDevice for now, so that we can use screen sharing.

We'll probably need to reopen this when we'll want more control over which GPU is used.

Closed by 301020ee9a

I'll just use `layer.preferredDevice` for now, so that we can use screen sharing. We'll probably need to reopen this when we'll want more control over which GPU is used. Closed by 301020ee9a

MartinFouilleul closed this issue

2023-07-07 08:56:59 +00:00

MartinFouilleul commented

2023-07-07 17:19:31 +00:00

This "fix" appears to break XCode's GPU Frame Capture...

MartinFouilleul reopened this issue

2023-07-07 17:19:31 +00:00

MartinFouilleul commented

2023-07-10 09:32:09 +00:00

Milepost commit a65b0cc1bb seems to fix both the discord issue and the XCode frame capture issue. Instead of calling MTLCreateSystemDefaultDevice(), we query the list of all available GPUs and iterate to find the discrete one, and otherwise fallback on the first one.

Milepost commit a65b0cc1bb seems to fix both the discord issue and the XCode frame capture issue. Instead of calling `MTLCreateSystemDefaultDevice()`, we query the list of all available GPUs and iterate to find the discrete one, and otherwise fallback on the first one.

MartinFouilleul closed this issue

2023-07-10 09:32:09 +00:00

Sign in to join this conversation.