hmn
/
orca
5
Fork 2
Code Issues 21 Pull Requests 1 Packages Projects Releases Wiki Activity

OnFrameResize() handler doesn't get passed the same values on macOS and Windows #17

New Issue
Closed
opened 2023-07-07 15:17:34 +00:00 by MartinFouilleul · 2 comments
MartinFouilleul commented 2023-07-07 15:17:34 +00:00
Collaborator
Copy Link

MP_EVENT_WINDOW_RESIZE event gets passed the window's contents rect on macos, but the window's frame (including title bar) on windows.
We can get either using mp_window_get_frame() or mp_window_get_content_rect(), but which one should the event itself contain?
Also, should the wasm apps be aware of their window frame, or only of their drawable contents rect?

`MP_EVENT_WINDOW_RESIZE` event gets passed the window's contents rect on macos, but the window's _frame_ (including title bar) on windows. We can get either using `mp_window_get_frame()` or `mp_window_get_content_rect()`, but which one should the event itself contain? Also, should the wasm apps be aware of their window frame, or only of their drawable contents rect?
bvisness commented 2023-07-09 14:39:23 +00:00
Owner
Copy Link

Browsers allow you to query both the "inner" and "outer" sizes of the window, and I think it would be fine for us to support both. That said, I think the size of the content area is far more important.

Browsers allow you to query both the ["inner"](https://developer.mozilla.org/en-US/docs/Web/API/Window/innerHeight) and ["outer"](https://developer.mozilla.org/en-US/docs/Web/API/Window/outerHeight) sizes of the window, and I think it would be fine for us to support both. That said, I think the size of the content area is far more important.
bvisness added this to the Jam MVP milestone 2023-07-09 14:46:58 +00:00
MartinFouilleul commented 2023-07-26 15:45:51 +00:00
Author
Collaborator
Copy Link

Fixed by 23f0d75e20. OnFrameResize() now receives the window contents dimensions on both platforms.

Fixed by 23f0d75e20. `OnFrameResize()` now receives the window _contents_ dimensions on both platforms.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
split_abort_dialog
zig_ffi
subprocess
fix_win_gles_vsync
disable-win32-vsync
fix_layout
docs-ben
vblank_notification
bytebox_integration
Labels
Clear labels   
macOS

   
windows
No Label
macOS
windows
Milestone
Clear milestone
No items
No Milestone
Jam MVP
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hmn/orca#17
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?