hmn
/
orca
5
Fork 2
Code Issues 21 Pull Requests 1 Packages Projects Releases Wiki Activity

Win32 app icon #4

New Issue
Open
opened 2023-06-26 09:46:49 +00:00 by MartinFouilleul · 4 comments
MartinFouilleul commented 2023-06-26 09:46:49 +00:00
Collaborator
Copy Link

When bundling an orca app for win32, change the name of the runtime executable to the name of the app and sets its icon according to the file passed to the --icon option.
(Alternatively we could just create a shortcut to the runtime executable in the app's directory, and set the icon of that shortcut?)

When bundling an orca app for win32, change the name of the runtime executable to the name of the app and sets its icon according to the file passed to the `--icon` option. (Alternatively we could just create a shortcut to the runtime executable in the app's directory, and set the icon of that shortcut?)
bvisness commented 2023-07-03 16:03:00 +00:00
Owner
Copy Link

I think it would be best to bundle the app icon into the executable itself so that Orca apps have more identity. Plus I don't know what would show up in the taskbar otherwise?

I think it would be best to bundle the app icon into the executable itself so that Orca apps have more identity. Plus I don't know what would show up in the taskbar otherwise?
MartinFouilleul commented 2023-07-04 07:49:29 +00:00
Author
Collaborator
Copy Link

Yeah agreed. Problem is we don't want to compile the runtime for every application just to pass the correct resource file for the icon. But I don't know if we can add resources to the executable after the fact without using an external tool like resource hacker?

Yeah agreed. Problem is we don't want to compile the runtime for every application just to pass the correct resource file for the icon. But I don't know if we can add resources to the executable after the fact without using an external tool like resource hacker?
bvisness commented 2023-07-04 16:45:30 +00:00
Owner
Copy Link

Well ideally I think I would want Orca apps on Windows to be a single executable with the wasm data bundled in, and in that case we'd be in the business of making executables anyway. But I'm not sure how easy that is or if it's reasonable for our MVP.

Well ideally I think I would want Orca apps on Windows to be a single executable with the wasm data bundled in, and in that case we'd be in the business of making executables anyway. But I'm not sure how easy that is or if it's reasonable for our MVP.
MartinFouilleul commented 2023-07-05 07:36:47 +00:00
Author
Collaborator
Copy Link

I though about this but I don't think it's going to work great for three reasons:

  • We'll probably have to bundle some dlls along with the exectuable anyway (e.g. angle, currently milepost and pthreads - although we'll probably remove them).
  • It changes how the runtime loads the wasm module, in a platform-dependent way.
  • The launcher will deal with 'unbundled' apps, i.e. just wasm modules and resources. We'll want the ability to easily bundle and un-bundle apps, so that they can be distributed and used as free-standing apps or be integrated to the launcher's collection.

Additionally my guess is that it also wouldn't play very well with dynamic linking and applications embedding when we tackle that later on, but that one is more hypothetical.

I though about this but I don't think it's going to work great for three reasons: * We'll probably have to bundle some dlls along with the exectuable anyway (e.g. angle, currently milepost and pthreads - although we'll probably remove them). * It changes how the runtime loads the wasm module, in a platform-dependent way. * The launcher will deal with 'unbundled' apps, i.e. just wasm modules and resources. We'll want the ability to easily bundle and un-bundle apps, so that they can be distributed and used as free-standing apps or be integrated to the launcher's collection. Additionally my guess is that it also wouldn't play very well with dynamic linking and applications embedding when we tackle that later on, but that one is more hypothetical.
bvisness added the
windows
 label 2023-09-17 14:59:38 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
split_abort_dialog
zig_ffi
subprocess
fix_win_gles_vsync
disable-win32-vsync
fix_layout
docs-ben
vblank_notification
bytebox_integration
Labels
Clear labels   
macOS

   
windows
No Label
macOS
windows
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hmn/orca#4
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?