oc_clock_init() called in oc_init() platform mismatch #66

New Issue

rdunnington · 2023-08-24T19:35:57Z

rdunnington commented

2023-08-24 19:35:57 +00:00

oc_clock_init() is called in oc_init() on osx_app.m. But it isn't called in the corresponding oc_init() in win32_app.c.

I'm mainly opening this because I'm not sure what the intended behavior should be - if orca apps are intended to call oc_clock_init() or let the platform handle it.

`oc_clock_init()` is called in `oc_init()` on osx_app.m. But it isn't called in the corresponding `oc_init()` in win32_app.c. I'm mainly opening this because I'm not sure what the intended behavior should be - if orca apps are intended to call `oc_clock_init()` or let the platform handle it.

ilidemi commented

2023-08-24 21:28:24 +00:00

Platform is supposed to be the one handling it, the clock init function is not exposed to wasm.
Context: #18 (comment)

Platform is supposed to be the one handling it, the clock init function is not exposed to wasm. Context: https://git.handmade.network/hmn/orca/pulls/18#issuecomment-1433

rdunnington commented

2023-08-24 22:35:22 +00:00

Cool, ty. I'll open a PR for this

rdunnington referenced a pull request that will close this issue

2023-08-24 22:36:11 +00:00

win32: initialize clock in oc_init() #67

MartinFouilleul closed this issue

2023-08-25 13:39:05 +00:00

Sign in to join this conversation.