From 38e93d5208213c710756c225854b18f5811b88c4 Mon Sep 17 00:00:00 2001
From: Asaf Gartner <asaf@handmadedev.org>
Date: Thu, 7 Apr 2022 08:19:48 +0300
Subject: [PATCH] Added support for unknown filetypes in snippets

---
 public/js/showcase.js                        |  1 +
 src/templates/src/include/timeline_item.html |  4 ++++
 src/templates/src/snippet.html               |  4 ++++
 src/templates/templates.go                   | 19 +++++++++++++++++++
 src/templates/types.go                       |  5 ++++-
 src/website/timeline_helper.go               | 17 ++++++++++++++++-
 6 files changed, 48 insertions(+), 2 deletions(-)

diff --git a/public/js/showcase.js b/public/js/showcase.js
index 1f39ab09..aa2b5ef9 100644
--- a/public/js/showcase.js
+++ b/public/js/showcase.js
@@ -1,4 +1,5 @@
 const TimelineMediaTypes = {
+	UNKNOWN: 0,
     IMAGE: 1,
     VIDEO: 2,
     AUDIO: 3,
diff --git a/src/templates/src/include/timeline_item.html b/src/templates/src/include/timeline_item.html
index 285fb6b9..9caa4680 100644
--- a/src/templates/src/include/timeline_item.html
+++ b/src/templates/src/include/timeline_item.html
@@ -56,6 +56,10 @@
 				<audio src="{{ .AssetUrl }}" controls>
 			{{ else if eq .Type mediaembed }}
 				{{ .EmbedHTML }}
+			{{ else }}
+				<div class="project-card br2 pv1 ph2">
+					<a href="{{ .AssetUrl }}" target="_blank">{{ .Filename }} ({{ filesize .FileSize }})</a>
+				</div>
 			{{ end }}
 		</div>
 	{{ end }}
diff --git a/src/templates/src/snippet.html b/src/templates/src/snippet.html
index 1ea1c8f5..c0066339 100644
--- a/src/templates/src/snippet.html
+++ b/src/templates/src/snippet.html
@@ -21,6 +21,10 @@
                     <div class="mb3 aspect-ratio aspect-ratio--16x9">
                         {{ .EmbedHTML }}
                     </div>
+				{{ else }}
+					<div class="project-card br2 pv1 ph2">
+						<a href="{{ .AssetUrl }}" target="_blank">{{ .Filename }} ({{ filesize .FileSize }})</a>
+					</div>
                 {{ end }}
             {{ end }}
         </div>
diff --git a/src/templates/templates.go b/src/templates/templates.go
index 7be682ac..ea07108f 100644
--- a/src/templates/templates.go
+++ b/src/templates/templates.go
@@ -193,6 +193,25 @@ var HMNTemplateFuncs = template.FuncMap{
 	"noescape": func(str string) template.HTML {
 		return template.HTML(str)
 	},
+	"filesize": func(numBytes int) string {
+		scales := []string{
+			" bytes",
+			"kb",
+			"mb",
+			"gb",
+		}
+		num := float64(numBytes)
+		scale := 0
+		for num > 1024 && scale < len(scales)-1 {
+			num /= 1024
+			scale += 1
+		}
+		precision := 0
+		if scale > 0 {
+			precision = 2
+		}
+		return fmt.Sprintf("%.*f%s", precision, num, scales[scale])
+	},
 
 	// NOTE(asaf): Template specific functions:
 	"projectcarddata": func(project Project, classes string) ProjectCardData {
diff --git a/src/templates/types.go b/src/templates/types.go
index 84832dfd..6077b49c 100644
--- a/src/templates/types.go
+++ b/src/templates/types.go
@@ -305,7 +305,8 @@ type TimelineItem struct {
 type TimelineItemMediaType int
 
 const (
-	TimelineItemMediaTypeImage TimelineItemMediaType = iota + 1
+	TimelineItemMediaTypeUnknown TimelineItemMediaType = iota
+	TimelineItemMediaTypeImage
 	TimelineItemMediaTypeVideo
 	TimelineItemMediaTypeAudio
 	TimelineItemMediaTypeEmbed
@@ -318,6 +319,8 @@ type TimelineItemMedia struct {
 	ThumbnailUrl        string
 	MimeType            string
 	Width, Height       int
+	Filename            string
+	FileSize            int
 	ExtraOpenGraphItems []OpenGraphItem
 }
 
diff --git a/src/website/timeline_helper.go b/src/website/timeline_helper.go
index e24cb058..7db76cc8 100644
--- a/src/website/timeline_helper.go
+++ b/src/website/timeline_helper.go
@@ -89,6 +89,8 @@ func SnippetToTimelineItem(
 			item.EmbedMedia = append(item.EmbedMedia, videoMediaItem(asset))
 		} else if strings.HasPrefix(asset.MimeType, "audio/") {
 			item.EmbedMedia = append(item.EmbedMedia, audioMediaItem(asset))
+		} else {
+			item.EmbedMedia = append(item.EmbedMedia, unknownMediaItem(asset))
 		}
 	}
 
@@ -100,7 +102,8 @@ func SnippetToTimelineItem(
 		}
 	}
 
-	if len(item.EmbedMedia) > 0 && (item.EmbedMedia[0].Width == 0 || item.EmbedMedia[0].Height == 0) {
+	if len(item.EmbedMedia) == 0 ||
+		(len(item.EmbedMedia) > 0 && (item.EmbedMedia[0].Width == 0 || item.EmbedMedia[0].Height == 0)) {
 		item.CanShowcase = false
 	}
 
@@ -185,3 +188,15 @@ func youtubeMediaItem(videoId string) templates.TimelineItemMedia {
 		},
 	}
 }
+
+func unknownMediaItem(asset *models.Asset) templates.TimelineItemMedia {
+	assetUrl := hmnurl.BuildS3Asset(asset.S3Key)
+
+	return templates.TimelineItemMedia{
+		Type:     templates.TimelineItemMediaTypeUnknown,
+		AssetUrl: assetUrl,
+		MimeType: asset.MimeType,
+		Filename: asset.Filename,
+		FileSize: asset.Size,
+	}
+}