Rename the email override field for clarity #26

bvisness · 2022-05-25T22:40:50Z

bvisness commented

2022-05-25 22:40:50 +00:00

Cloin and I were confused by the previous name, thinking that it was some address that people could use to override something (?). I renamed it both for clarity and for consistency with the FromAddress field above.

The reason I'm having you review this is because it will break config for people and wanted you to be aware of it. For now the only people it will affect are us, cloin, and Nick12. I think.

In the future maybe we can do some kind of graceful migration thing, but it didn't feel worth it.

Cloin and I were confused by the previous name, thinking that it was some address that people could use to override something (?). I renamed it both for clarity and for consistency with the `FromAddress` field above. The reason I'm having you review this is because it will break config for people and wanted you to be aware of it. For now the only people it will affect are us, cloin, and Nick12. I think. In the future maybe we can do some kind of graceful migration thing, but it didn't feel worth it.

bvisness added 1 commit 2022-05-25 22:40:50 +00:00

68a00c91db Rename the email override field for clarity

bvisness commented

2022-05-25 22:42:58 +00:00

also can I just say that's so nice to be able to use IDE renaming features on config variables, instead of everything being lost in a maze of YAML

bvisness merged commit 68a00c91db into master

2022-05-26 12:54:58 +00:00

bvisness deleted branch rename-email-override

2022-05-26 12:54:58 +00:00

Sign in to join this conversation.

No reviewers