New buttons with project colors + small bugfix #80

giggs · 2022-08-02T04:38:12Z

giggs commented

2022-08-02 04:38:12 +00:00

Following the discussion on #74, here are changes to the submit buttons so that they match theme/project color.

Border colors are set to match the button background.

I've also included a "bugfix" where the editor-toolbar-button-background parameter in the dark theme.css and variables.scss were missing the # sign.

I wasn't sure whether to remove the form button values from theme.css and variables.scss and left them, as I'm not sure they're used anywhere now

Following the discussion on [#74](https://git.handmade.network/hmn/hmn/issues/74), here are changes to the submit buttons so that they match theme/project color. Border colors are set to match the button background. I've also included a "bugfix" where the `editor-toolbar-button-background` parameter in the dark theme.css and variables.scss were missing the # sign. I wasn't sure whether to remove the `form button` values from theme.css and variables.scss and left them, as I'm not sure they're used anywhere now

preview.png

83 KiB

giggs added 1 commit 2022-08-02 04:38:13 +00:00

af1cf96703 New buttons with project colors + small bugfix

giggs commented

2022-08-02 04:48:21 +00:00

~~Unfortunately there are issues with the buttons in the Add project pages, trying to fix it~~

I think they're all fixed now

~~Unfortunately there are issues with the buttons in the Add project pages, trying to fix it~~ I think they're all fixed now

giggs added 1 commit 2022-08-02 05:07:45 +00:00

023633e673 Fixed New project button

giggs added 1 commit 2022-08-02 05:18:50 +00:00

1a11e9c85e more fixes

bvisness commented

2022-08-09 23:05:43 +00:00

Thanks, I really like how these changes are looking! Unfortunately I've noticed a problem, which is that while your CSS changes are good, you're directly editing the CSS files, which are generated by running go run . buildscss and not supposed to be edited directly. So, the next time someone runs that, they'll be overridden.

Any changes you've made to style.css should be ported to the relevant .scss files, and then run go run . buildscss to ensure that everything is set up correctly.

Thanks, I really like how these changes are looking! Unfortunately I've noticed a problem, which is that while your CSS changes are good, you're directly editing the CSS files, which are generated by running `go run . buildscss` and not supposed to be edited directly. So, the next time someone runs that, they'll be overridden. Any changes you've made to `style.css` should be ported to the relevant `.scss` files, and then run `go run . buildscss` to ensure that everything is set up correctly.

giggs added 1 commit 2022-08-10 14:42:39 +00:00

76acf34cb0 scss modification

giggs commented

2022-08-10 14:59:34 +00:00

Thanks, I really like how these changes are looking! Unfortunately I've noticed a problem, which is that while your CSS changes are good, you're directly editing the CSS files, which are generated by running go run . buildscss and not supposed to be edited directly. So, the next time someone runs that, they'll be overridden.

Any changes you've made to style.css should be ported to the relevant .scss files, and then run go run . buildscss to ensure that everything is set up correctly.

I modified _forms.scss and after running go run . buildscss it's all good locally. Unfortunately it seems like rebuilding the scss made git think there are hundreds of non-existant changes to style.css, which I have no idea how to fix. Hopefully it doesn't matter.

project.css was unaffected by the rebuild and indeed, it doesn't appear in buildscss.go so I left that unchaged.

It also occurred to me that the fix I'd done for the squeeshed avatars was also improperly implemented by editing style.css so I fixed that, too.

I do appreciate your patience as I stumble through this learning process, thank you.

> Thanks, I really like how these changes are looking! Unfortunately I've noticed a problem, which is that while your CSS changes are good, you're directly editing the CSS files, which are generated by running `go run . buildscss` and not supposed to be edited directly. So, the next time someone runs that, they'll be overridden. > > Any changes you've made to `style.css` should be ported to the relevant `.scss` files, and then run `go run . buildscss` to ensure that everything is set up correctly. I modified `_forms.scss` and after running `go run . buildscss` it's all good locally. Unfortunately it seems like rebuilding the scss made git think there are hundreds of non-existant changes to `style.css`, which I have no idea how to fix. Hopefully it doesn't matter. `project.css` was unaffected by the rebuild and indeed, it doesn't appear in `buildscss.go` so I left that unchaged. It also occurred to me that the fix I'd done for the squeeshed avatars was also improperly implemented by editing `style.css` so I fixed that, too. I do appreciate your patience as I stumble through this learning process, thank you.

giggs added 1 commit 2022-08-10 15:07:23 +00:00

1f87d52f88 fixed avatar squeeshing properly

bvisness commented

2022-08-13 02:12:50 +00:00

Looks great to me now! No worries about the style.css changes; it's probably line ending stuff and I really don't care. Thanks for making these changes!

bvisness merged commit 9e786e132d into master

2022-08-13 02:13:14 +00:00

bvisness referenced this issue from a commit

2022-08-13 02:13:14 +00:00

New buttons with project colors + small bugfix (#80)

bvisness referenced this pull request

2022-08-16 13:01:55 +00:00

Buttons are dim and boring #74

Sign in to join this conversation.

No reviewers