hmn
/
orca
5
Fork 2
Code Issues 21 Pull Requests 1 Packages Projects Releases Wiki Activity

Only highlight the widgets on mouse down when they are also hovered #106

Merged
MartinFouilleul merged 3 commits from ilidemi/orca:fix-hovered-active into main 2023-09-16 14:41:21 +00:00
Conversation 2 Commits 3 Files Changed 2 +95 -67
ilidemi commented 2023-09-15 22:01:00 +00:00
Collaborator
Copy Link
No description provided.
ilidemi added 1 commit 2023-09-15 22:01:01 +00:00
ilidemi commented 2023-09-15 22:09:09 +00:00
Author
Collaborator
Copy Link

This could be further improved if OC_UI_HOVER would become OC_UI_HOT and look at box->hot. Radio buttons are set to hot when the mouse is hovering the label, checkboxes ideally could be too. I haven't thought through the possible side effects so not changing it here.

This could be further improved if `OC_UI_HOVER` would become `OC_UI_HOT` and look at `box->hot`. Radio buttons are set to hot when the mouse is hovering the label, checkboxes ideally could be too. I haven't thought through the possible side effects so not changing it here.
MartinFouilleul added 1 commit 2023-09-16 14:18:43 +00:00
MartinFouilleul added 1 commit 2023-09-16 14:33:14 +00:00
MartinFouilleul commented 2023-09-16 14:41:01 +00:00
Collaborator
Copy Link

Buttons were not reverting to default style when active but not hovered. I added a pattern element to ensure they are only highlighted when they are hovered or hovered and active.

I also added a OC_UI_HOT style selector to do what you suggested with the radio buttons. I didn't change checkboxes because they come without a label for now.

As an aside, I feel like the hot/active nomenclature is a bit confusing, since for buttons it really maps hovered/dragging but users might think of "active" as "will trigger if released"... so maybe we could change that and use better names.

Buttons were not reverting to default style when active but not hovered. I added a pattern element to ensure they are only highlighted when they are hovered or hovered _and_ active. I also added a `OC_UI_HOT` style selector to do what you suggested with the radio buttons. I didn't change checkboxes because they come without a label for now. As an aside, I feel like the hot/active nomenclature is a bit confusing, since for buttons it really maps hovered/dragging but users might think of "active" as "will trigger if released"... so maybe we could change that and use better names.
MartinFouilleul merged commit 300d5aeab4 into main 2023-09-16 14:41:21 +00:00
MartinFouilleul referenced this issue from a commit 2023-09-16 15:06:24 +00:00
[ui layout]
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
macOS

   
windows
No Label
macOS
windows
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hmn/orca#106
No description provided.
Delete Branch "ilidemi/orca:fix-hovered-active"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?