hmn
/
orca
5
Fork 2
Code Issues 21 Pull Requests 1 Packages Projects Releases Wiki Activity

Radio button group #101

Merged
MartinFouilleul merged 2 commits from ilidemi/orca:radio-button into main 2023-09-14 07:40:29 +00:00
Conversation 2 Commits 2 Files Changed 3 +169 -2
ilidemi commented 2023-09-13 02:33:25 +00:00
Collaborator
Copy Link
No description provided.
ilidemi force-pushed radio-button from 78c254630d to 0fc6136215 2023-09-13 07:43:36 +00:00 Compare
MartinFouilleul commented 2023-09-13 15:13:48 +00:00
Collaborator
Copy Link

I see you changed the way boxes are drawn, putting the border inside the box and clipping on the true box. Why was that preferable that way, and did you check the change doesn't interfere with auto-layout code?

I see you changed the way boxes are drawn, putting the border inside the box and clipping on the true box. Why was that preferable that way, and did you check the change doesn't interfere with auto-layout code?
ilidemi force-pushed radio-button from 0fc6136215 to d44ac5a1fb 2023-09-13 21:03:37 +00:00 Compare
ilidemi commented 2023-09-13 21:08:50 +00:00
Author
Collaborator
Copy Link

Selected radio button was initially represented as a white box with thick blue border which I thought would allow for easier styling. The border would need to be included in the dimensions of the rect to not mess up the layout. I now see that color+bgColor is a more intuitive combo than bgColor+borderColor so changed that to a proc (however trivial).

There is a minor ick that the menu panel borders are half a px out of alignment with the menu button and having borders within the rect would fix that along with similar future issues but that's too minor to justify redoing the borders here.

Layout-wise, the logic only looks at box->rect which would stay the same, just the drawn border would now move inward. But let's leave that for the future.

Selected radio button was initially represented as a white box with thick blue border which I thought would allow for easier styling. The border would need to be included in the dimensions of the rect to not mess up the layout. I now see that color+bgColor is a more intuitive combo than bgColor+borderColor so changed that to a proc (however trivial). There is a minor ick that the menu panel borders are half a px out of alignment with the menu button and having borders within the rect would fix that along with similar future issues but that's too minor to justify redoing the borders here. Layout-wise, the logic only looks at box->rect which would stay the same, just the drawn border would now move inward. But let's leave that for the future.
👍 1
MartinFouilleul merged commit d44ac5a1fb into main 2023-09-14 07:40:29 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
macOS

   
windows
No Label
macOS
windows
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hmn/orca#101
No description provided.
Delete Branch "ilidemi/orca:radio-button"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?