hmn
/
orca
5
Fork 2
Code Issues 21 Pull Requests 1 Packages Projects Releases Wiki Activity

windows: fix vsync logspam when window is minimized #134

Merged
MartinFouilleul merged 1 commits from fix-minimize-logspam into main 2023-09-19 06:43:12 +00:00
Conversation 0 Commits 1 Files Changed 1 +9 -8
rdunnington commented 2023-09-19 04:09:56 +00:00
Collaborator
Copy Link

When a window is minimized, it isn't present on any monitor, so this log would get spammed every frame:

Warning: E:\Dev\handmade\orca\src\graphics/win32_vsync.c() in oc_vsync_wait:153: No outputs found. Were all monitors unplugged?

This change falls back to the last found monitor, if there is one, to avoid hogging the CPU, and removes the logspam.

When a window is minimized, it isn't present on any monitor, so this log would get spammed every frame: ``` Warning: E:\Dev\handmade\orca\src\graphics/win32_vsync.c() in oc_vsync_wait:153: No outputs found. Were all monitors unplugged? ``` This change falls back to the last found monitor, if there is one, to avoid hogging the CPU, and removes the logspam.
MartinFouilleul force-pushed fix-minimize-logspam from 6a6e566686 to ea74114693 2023-09-19 06:43:00 +00:00 Compare
MartinFouilleul merged commit ea74114693 into main 2023-09-19 06:43:12 +00:00
MartinFouilleul deleted branch fix-minimize-logspam 2023-09-19 06:43:12 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
macOS

   
windows
No Label
macOS
windows
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hmn/orca#134
No description provided.
Delete Branch "fix-minimize-logspam"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?