Fix wasm3 alignment errors and silence some warnings #135

MartinFouilleul · 2023-09-19T08:01:40Z

MartinFouilleul commented

2023-09-19 08:01:40 +00:00

Close #129

MartinFouilleul added 3 commits 2023-09-19 08:01:41 +00:00

370482a3e0 remove wrong alignment attribute of IM3Operation wasm3

715ab0f6e3 put mtl renderer constants in an enum to silence -Wgnu-folding-constant warnings

ecf89fa6b2 [macos build]

- Remove the need for -maes, silence warning about ignored option on ARM macs
- Set -mmacos-version-min when building wasm3 to match that of the platform layer and runtime

MartinFouilleul referenced this pull request

2023-09-19 08:03:39 +00:00

MacOS build-runtime wasm compilation errors #129

Khrob commented

2023-09-19 09:34:00 +00:00

First-time contributor

Most warnings are gone - complete output as follows:

orca dev build-runtime

Building Orca platform layer...
In file included from src/orca.m:19:
src/graphics/mtl_renderer.m:518:13: warning: variable length array folded to constant array as an extension [-Wgnu-folding-constant]
        f32 checkSamples[CHECK_SAMPLE_COUNT] = { 1. / 6, 2. / 6, 3. / 6, 4. / 6, 5. / 6 };
            ^
src/graphics/mtl_renderer.m:620:13: warning: variable length array folded to constant array as an extension [-Wgnu-folding-constant]
        f32 checkSamples[CHECK_SAMPLE_COUNT] = { 1. / 6, 2. / 6, 3. / 6, 4. / 6, 5. / 6 };
            ^
2 warnings generated.
Building wasm3...
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: build/lib/libwasm3.a(m3_api_wasi.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: build/lib/libwasm3.a(m3_api_tracer.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: build/lib/libwasm3.a(m3_api_uvwasi.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: build/lib/libwasm3.a(m3_api_meta_wasi.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: build/lib/libwasm3.a(m3_exec.o) has no symbols
Building Orca runtime...
Task completed successfully.

Most warnings are gone - complete output as follows: ``` orca dev build-runtime Building Orca platform layer... In file included from src/orca.m:19: src/graphics/mtl_renderer.m:518:13: warning: variable length array folded to constant array as an extension [-Wgnu-folding-constant] f32 checkSamples[CHECK_SAMPLE_COUNT] = { 1. / 6, 2. / 6, 3. / 6, 4. / 6, 5. / 6 }; ^ src/graphics/mtl_renderer.m:620:13: warning: variable length array folded to constant array as an extension [-Wgnu-folding-constant] f32 checkSamples[CHECK_SAMPLE_COUNT] = { 1. / 6, 2. / 6, 3. / 6, 4. / 6, 5. / 6 }; ^ 2 warnings generated. Building wasm3... /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: build/lib/libwasm3.a(m3_api_wasi.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: build/lib/libwasm3.a(m3_api_tracer.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: build/lib/libwasm3.a(m3_api_uvwasi.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: build/lib/libwasm3.a(m3_api_meta_wasi.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: build/lib/libwasm3.a(m3_exec.o) has no symbols Building Orca runtime... Task completed successfully. ```

Khrob commented

2023-09-19 09:43:25 +00:00

First-time contributor

changing

const int CHECK_SAMPLE_COUNT = 5;

to

enum { CHECK_SAMPLE_COUNT = 5 };

silenced those ones for me.

changing `const int CHECK_SAMPLE_COUNT = 5;` to `enum { CHECK_SAMPLE_COUNT = 5 };` silenced those ones for me.

MartinFouilleul added 2 commits 2023-09-19 09:48:50 +00:00

647565e285 Put offset curve sample check count in an enum to silence -Wgnu-folding-constant

94ce88e272 [macos] use libtool instead of ar when building wasm3 lib, and pass -no_warning_for_no_symbols because translation units in wasm3 don't have symbols