hmn
/
orca
5
Fork 2
Code Issues 21 Pull Requests 1 Packages Projects Releases Wiki Activity

Use textbox shortcuts from the host platform #52

Merged
MartinFouilleul merged 3 commits from ilidemi/orca:platform-text-edit into main 2023-08-22 20:15:22 +00:00
Conversation 1 Commits 3 Files Changed 8 +214 -29
ilidemi commented 2023-08-22 08:13:25 +00:00
Collaborator
Copy Link

Fixes half of ☐4 from #30. Names are picked somewhat arbitrarily, open to feedback. Builds on !50, hopefully rebase/merge should clear that out. Invisible changes on comments are line endings, looks like some comments have CRLF committed.

Fixes half of ☐4 from #30. Names are picked somewhat arbitrarily, open to feedback. Builds on !50, hopefully rebase/merge should clear that out. Invisible changes on comments are line endings, looks like some comments have CRLF committed.
ilidemi added 1 commit 2023-08-22 08:13:26 +00:00
MartinFouilleul commented 2023-08-22 12:18:29 +00:00
Collaborator
Copy Link

You can bind orca_get_host_platform() directly without having a forwarding oc_get_host_platform_impl().

Also, I think it's still useful to keep OC_KEYMOD_MAIN_MODIFIER around as a convenience for people who want to implement custom shortcut for their app, but don't want/need to deal with choosing which modifier to use depending on the platform.

You can bind `orca_get_host_platform()` directly without having a forwarding `oc_get_host_platform_impl()`. Also, I think it's still useful to keep `OC_KEYMOD_MAIN_MODIFIER` around as a convenience for people who want to implement custom shortcut for their app, but don't want/need to deal with choosing which modifier to use depending on the platform.
ilidemi added 2 commits 2023-08-22 16:43:51 +00:00
MartinFouilleul merged commit 2c07c9b665 into main 2023-08-22 20:15:22 +00:00
MartinFouilleul deleted branch platform-text-edit 2023-08-22 20:15:22 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
macOS

   
windows
No Label
macOS
windows
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hmn/orca#52
No description provided.
Delete Branch "ilidemi/orca:platform-text-edit"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?