Fix clock rendering artifact #62

ilidemi · 2023-08-24T00:09:16Z

ilidemi commented

2023-08-24 00:09:16 +00:00

When rounded rect corner radius exceeds 2 * height, it stops looking like a rect. Proper fix would be to introduce clamping in oc_rounded_rectangle_path but that needs some investigation, what's the standard way of applying it.

When rounded rect corner radius exceeds 2 * height, it stops looking like a rect. Proper fix would be to introduce clamping in oc_rounded_rectangle_path but that needs some investigation, what's the standard way of applying it. ![image](/attachments/af98c764-1007-46ff-8e58-555c6a15850c)

image.png

1.1 KiB

ilidemi added 1 commit 2023-08-24 00:09:17 +00:00

543feffea9 Fix clock rendering artifact

bvisness commented

2023-08-24 01:59:26 +00:00

Standard way I think would be min(height, width) / 2. Might be different if you can apply a different radius to each corner - which we will probably want in some form at some point. You can also enforce different horizontal and vertical radii to get elliptical corners. Never seen anyone use that in the wild though.

Standard way I think would be `min(height, width) / 2`. Might be different if you can apply a different radius to each corner - which we will probably want in some form at some point. You can also enforce different horizontal and vertical radii to get elliptical corners. Never seen anyone use that in the wild though.

ilidemi referenced this pull request

2023-08-24 03:04:59 +00:00

Clamp rounded rect radius #64

ilidemi commented

2023-08-24 03:05:58 +00:00

That's easier than I thought! Reviewer(s), feel free to choose between this and !64.