hmn
/
orca
5
Fork 2
Code Issues 21 Pull Requests 1 Packages Projects Releases Wiki Activity

Support move/select/delete word with keyboard in textbox #63

Merged
MartinFouilleul merged 2 commits from ilidemi/orca:text-box-words into main 2023-08-25 13:50:15 +00:00
Conversation 1 Commits 2 Files Changed 3 +163 -11
ilidemi commented 2023-08-24 02:47:32 +00:00
Collaborator
Copy Link

Fixes ☐4 from #30. Created #68 to track the remaining gaps.

A simple word break algorithm borrowed from Qt. Proper implementation would involve bringing in ICU or querying unicode ranges and parsing ICU rules but we're not there yet.

Ideally on macos option+right should move to the end of the word instead of the beginning of the next one but this might interact with cycling shift+option+left/shift+option+right and I don't have a mac to map the potential intricacies.

Would appreciate someone testing on a mac.

Fixes ☐4 from #30. Created #68 to track the remaining gaps. A simple word break algorithm borrowed from Qt. Proper implementation would involve bringing in ICU or querying unicode ranges and parsing ICU rules but we're not there yet. Ideally on macos option+right should move to the end of the word instead of the beginning of the next one but this might interact with cycling shift+option+left/shift+option+right and I don't have a mac to map the potential intricacies. Would appreciate someone testing on a mac.
MartinFouilleul force-pushed text-box-words from 76cdd0a89c to 3c199dce34 2023-08-25 13:49:34 +00:00 Compare
MartinFouilleul merged commit 0727466f48 into main 2023-08-25 13:50:15 +00:00
MartinFouilleul deleted branch text-box-words 2023-08-25 13:50:15 +00:00
MartinFouilleul commented 2023-08-28 11:01:26 +00:00
Collaborator
Copy Link

re: macos option+left/right, I don't know if we want to preserve OS conventions (which aren't necessarily agreed upon by non-Apple applications), or make conventions consistent across Orca apps, independent of the underlying platform...

fwiw, cycling shift+option+left/shift+option+right on TextEdit stops at begining of word / end of word (like shift+left/shift+right would), plus on the original cursor position (see video attached)

re: macos option+left/right, I don't know if we want to preserve OS conventions (which aren't necessarily agreed upon by non-Apple applications), or make conventions consistent across Orca apps, independent of the underlying platform... fwiw, cycling shift+option+left/shift+option+right on TextEdit stops at begining of word / end of word (like shift+left/shift+right would), plus on the original cursor position (see video attached)
Enregistrement de l’écran 2023-08-28 à 12.58.45.mov
3.9 MiB
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
macOS

   
windows
No Label
macOS
windows
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hmn/orca#63
No description provided.
Delete Branch "ilidemi/orca:text-box-words"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?