hmn
/
orca
5
Fork 2
Code Issues 21 Pull Requests 1 Packages Projects Releases Wiki Activity

WIP: vblank_notification #70

Closed
rdunnington wants to merge 0 commits from vblank_notification into main
pull from: vblank_notification
merge into: hmn:main
Conversation 3 Commits - Files Changed - +281 -2
rdunnington commented 2023-08-28 03:53:51 +00:00
Collaborator
Copy Link

Still need to properly do shutdown.

Still need to properly do shutdown.
MartinFouilleul commented 2023-08-28 08:42:55 +00:00
Collaborator
Copy Link

Unfortunately this stutters a lot on my macbook, with both integrated and discrete graphics
it seems like the CVDisplayLink callback is called sometime before actually switching surfaces, not right after switching surfaces. So depending on the time it takes to pick the event from the queue and draw stuff, you can miss a surface swap, and the surface gets queued instead of presented (And next time you have a one too many surfaces, so one of them apparently gets skipped).

Unfortunately this stutters a lot on my macbook, with both integrated and discrete graphics it seems like the CVDisplayLink callback is called sometime before actually switching surfaces, not right after switching surfaces. So depending on the time it takes to pick the event from the queue and draw stuff, you can miss a surface swap, and the surface gets queued instead of presented (And next time you have a one too many surfaces, so one of them apparently gets skipped).
surface_stutter.png
844 KiB
surface_stutter.png
MartinFouilleul commented 2023-08-28 08:43:17 +00:00
Collaborator
Copy Link

Compared to triple buffering here:

Compared to triple buffering here:
surface_buffered.png
697 KiB
surface_buffered.png
MartinFouilleul changed title from vblank_notification to WIP: vblank_notification 2023-08-29 16:14:01 +00:00
rdunnington commented 2023-08-30 03:17:22 +00:00
Author
Collaborator
Copy Link

I'll close this PR for now in favor of the temp changes where we block on the debug surface. I can open a new one later if we decide to go with this approach in the long run.

I'll close this PR for now in favor of the temp changes where we block on the debug surface. I can open a new one later if we decide to go with this approach in the long run.
rdunnington closed this pull request 2023-08-30 03:17:23 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
macOS

   
windows
No Label
macOS
windows
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hmn/orca#70
No description provided.
Delete Branch "vblank_notification"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?