hmn
/
orca
5
Fork 2
Code Issues 21 Pull Requests 1 Packages Projects Releases Wiki Activity

Fix spinlock on close when debug overlay is displayed on Windows #77

Merged
MartinFouilleul merged 1 commits from fix_overlay_crash_on_close into main 2023-08-30 10:15:09 +00:00
Conversation 0 Commits 1 Files Changed 2 +5 -3
MartinFouilleul commented 2023-08-30 10:14:59 +00:00
Collaborator
Copy Link

Use app->quit on main thread instead of oc_should_quit(), to ensure that runloop_thread always exits its event loop before main thread.

Closes #75

Use app->quit on main thread instead of oc_should_quit(), to ensure that runloop_thread always exits its event loop before main thread. Closes #75
MartinFouilleul added 1 commit 2023-08-30 10:15:00 +00:00
MartinFouilleul merged commit 19ce7447aa into main 2023-08-30 10:15:09 +00:00
MartinFouilleul deleted branch fix_overlay_crash_on_close 2023-08-30 10:15:09 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
macOS

   
windows
No Label
macOS
windows
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hmn/orca#77
No description provided.
Delete Branch "fix_overlay_crash_on_close"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?