Fix leak in canvas code and samples #60

MartinFouilleul · 2023-08-23T14:32:52Z

MartinFouilleul commented

2023-08-23 14:32:52 +00:00

A number of functions in graphics_common.c where assuming oc_scratch() to be cleared at the end of the frame. We don't assume that anymore, so use oc_scratch_begin()/oc_scratch_end() instead.
(Samples can use still oc_scratch() directly since they control when to clear it, but now it's not necessary for canvas command buffer to work properly.)

Closes #42.

A number of functions in `graphics_common.c` where assuming `oc_scratch()` to be cleared at the end of the frame. We don't assume that anymore, so use `oc_scratch_begin()`/`oc_scratch_end()` instead. (Samples can use still `oc_scratch()` directly since they control when to clear it, but now it's not necessary for canvas command buffer to work properly.) Closes #42.

MartinFouilleul added 3 commits 2023-08-23 14:32:53 +00:00

86b1121fbe allow enabling/disabling metal frame capture when bundling a macos app

98f131cb30 Fix leak in metal surface: command buffer must not be committed if there is no surface to present it to, or it will result in a huge leak in metal resources. Also wrap oc_mtl_surface_acquire_command_buffer() in an @autoreleasepool to fix a smaller leak

42738195b5 Don't assume oc_scratch() is cleared at the frame boundary. Use oc_scratch_begin()/oc_scratch_end() instead

MartinFouilleul merged commit d3e27df818 into main

2023-08-23 14:33:22 +00:00

MartinFouilleul deleted branch fix_canvas_leak

2023-08-23 14:33:22 +00:00

MartinFouilleul referenced this issue from a commit

2023-08-23 14:33:23 +00:00

Merge pull request 'Fix leak in canvas code and samples' (#60) from fix_canvas_leak into main

Sign in to join this conversation.